-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support OCM geneva actions to get cluster info and to cancel cluster upgrade policy #3607
base: master
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree company="Microsoft" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't take a close look but can't we use https://github.com/openshift-online/ocm-sdk-go ?
Please rebase pull request. |
@bitoku This is a good question. I had planned to create two pull requests: one that does not use the OCM SDK and another that does. Given my previous PTO, I was only able to complete the PR that does not use the SDK first. I chose to prioritize this PR becuse the current case is strightforward and only requires the CX pull secret token. Therefore, the logic remains simple and avoiding the need to introduce numerous external dependencies to RP. In the long term, and from a functionality perspective, it might be beneficial to seperate the admin actions from RP since they are primarily used by SREs. I'll create another pull request that uses the OCM SDK so we can compare and decide which approach works best for us. |
Which issue this PR addresses:
ARO-7512 ARO-7513 ARO-7514 Support OCM geneva actions to get cluster info and to cancel cluster upgrade policy.
What this PR does / why we need it:
This project seeks to streamline ARO SRE operations when interacting with the OCM API by leveraging Geneva actions. Currently, ARO SREs must use SAW to operate customer clusters, and SAW does not allow direct API access to OCM api server, making it impossible to perform OCM-related tasks efficiently. This project proposes using Geneva actions to interact with the OCM api server using the customer's pull secret access token, easing the operational burden on ARO SREs.
Test plan for issue:
Unit tests invovled.
Is there any documentation that needs to be updated for this PR?
How do you know this will function as expected in production?
This change has been tested in dev cluster env.